Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding definition files for TS types #21

Closed
wants to merge 6 commits into from
Closed

Adding definition files for TS types #21

wants to merge 6 commits into from

Conversation

kinow
Copy link
Member

@kinow kinow commented Dec 18, 2020

Closes #13

@kinow kinow added this to the 1.1.1 milestone Dec 18, 2020
@kinow kinow changed the title Adding base files for TS types Adding definition files for TS types Dec 18, 2020
@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #21 (e0e2922) into master (1654547) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           52        52           
  Branches         1         1           
=========================================
  Hits            52        52           
Flag Coverage Δ
e2e 100.00% <ø> (ø)
unittests 47.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1654547...e0e2922. Read the comment docs.

@kinow
Copy link
Member Author

kinow commented Dec 18, 2020

Well, just need to learn how to include the definition type (need to switch to tsconfig?) and test it.

@kinow kinow marked this pull request as ready for review December 18, 2020 11:07
@kinow
Copy link
Member Author

kinow commented Dec 20, 2020

Alright, so the easiest route was to create an entry in https://github.com/DefinitelyTyped/DefinitelyTyped/, and ask users to import @types/node.

But looks like Vue2 had also vue add typescript, which would convert the project to TS, removing the necessity of DefinitelyTyped or trying to include a types definition file.

@kinow
Copy link
Member Author

kinow commented Dec 21, 2020

Work moved to #22

@kinow kinow closed this Dec 21, 2020
@kinow kinow deleted the add-types branch December 21, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript support
2 participants